Light wallet maintenance #9269
Open
Light wallet maintenance #9269
+1,013
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everoddandeven
force-pushed
the
light-wallet-maintenance
branch
from
4658493
to
81d4db0
Compare
everoddandeven
force-pushed
the
light-wallet-maintenance
branch
from
6ba2750
to
eedd59f
Compare
This was referenced Sep 21, 2024
everoddandeven
force-pushed
the
light-wallet-maintenance
branch
from
eedd59f
to
b200b6e
Compare
everoddandeven
force-pushed
the
light-wallet-maintenance
branch
from
b200b6e
to
ef2a1a5
Compare
woodser
reviewed
Oct 3, 2024
| continue; | ||
| } | ||
| } | ||
| uint64_t received = total_received; |
There was a problem hiding this comment.
This variable is not being used. Should it?
| } | ||
|
|
||
| // t can be 'outgoing', 'incoming' or 'both' | ||
| uint64_t fake_outputs_count = 0; |
There was a problem hiding this comment.
This variable isn't being used. Should it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes and improvements on wallet2::light_wallet* methods, in order to correctly connect to a light wallet server.